test(phase23): KEEP-VERIFY — remove 44 pass shells + fake INV tests, add shell guard

Phase 23 "可信系统测试重建 (REFACTOR)" re-audit. STATUS claimed "10 E2E
files / ~80+ cases" and "INV-011~020 ✅"; measurement showed the opposite.

D-23-A (Critical): V11InvariantsTest's 14 cases asserted only Constants
strings. INV-016 "Banner target types" actually asserted ARTICLE_STATUS_*;
INV-017 "home 8 entries" declared local arrays then asserted
firstRow.length == 4 (tautology, never called the home service);
INV-018/019/020 used appointment/article/account status constants as
stand-ins for permission and data-scope checks. Rewritten to 12 cases:
4 real service-behavior guards (INV-013 via real CounselingService.getDetail
— Matchmaker sees null userRequestSummary, with an assigned-Counselor
counter-proof so global sanitization cannot fake a pass; INV-016 reads the
production ALLOWED_TARGET_TYPES whitelist and asserts no external/http/url/
web entry; INV-017 calls real getHome and pins all 8 codes + order;
INV-019 asserts content_editor reads null), plus assertBehaviorTestExists
turning "行为验证见 XxxTest" pointers into executable Class.forName contracts.

D-23-B (High): 44 `pass` shells across 6 files in tests/e2e (4 files were
100% shells). Gate forbids skip/pass shells. Rewritten in place as honest
placeholders with the full scenario lists preserved.

D-23-C (High, residual): the pytest E2E suite is not executable at all —
no conftest.py anywhere, ~15 fixtures (api_client/verified_user/
banner_factory/...) do not exist. Only run_v11_tests.py really runs
(16 cases, needs a live stack + E2E_PASSWORD).

D-23-D (High, residual, NOT fixed): CI does not chain E2E as the plan
requires. Needs an infrastructure decision on how CI provisions a live
stack; not implemented rather than written unverified.

D-23-E (Medium): the CI migration job claimed to "验证 migration SQL 语法"
but only checked file non-emptiness, while the real syntax/baseline checks
live in MigrationValidationTest (already run by the backend job). Replaced
with a real sequence check (naming / non-empty / unique versions / no
gaps); verified by extracting the exact inline script and running it.

New gate: scripts/check-no-empty-tests.py (AST scan, blocks pass-only and
unconditionally skipped tests) + a CI test-shell-guard job. Verified both
ways: 0 findings on the real tree, 2 precise findings on injected shells.

Negative validation: 3 injected production defects (external_url in the
banner whitelist, swapped home entry order, isMatchmaker returning the full
record) turned exactly inv016/inv017/inv013 red, 9 others green, zero
unrelated failures; md5sum -c confirmed byte-identical restore.

Full regression: 655 tests / 652 passed / 0 failures / 0 errors / 3 skipped
(baseline 657; -2 because 14 vacuous cases were merged into 12). The 3
skips carry explicit reasons (2x @EnabledIfEnvironmentVariable(CI=true),
1x @Disabled "需要完整数据库连接") — none is a shell.

Phase 23 is PARTIALLY closed: fake coverage is gone, but the UAT gate
requires the end-to-end chain to actually execute, so "失败为零可进入 UAT"
is NOT claimed.

tests/e2e/activity_mutual_consent_test.py

@@ -1,57 +1,35 @@
 """
-V1.1 活动互选二阶段同意 E2E 测试骨架
-测试项目: 活动互选流程重构（INV-014, INV-015）
+V1.1 活动互选二阶段同意 E2E —— 空壳已移除（Phase 23 KEEP-VERIFY，2026-09-18）
+
+历史问题
+--------
+原文件 8 个测试函数**全部**为 `pass` 空壳（注释「TODO: P16 实现后完善」），
+依赖不存在的 `activity_factory` / `user_a` / `user_b` 等 fixture（全局无 `conftest.py`），
+从未执行过，却在 `docs/STATUS.md` 中被计为 P23-T11「活动互选 E2E ✅」。
+
+计划 Phase 23 Gate：「**不允许 skip/pass 空壳**」。
+
+当前状态
+--------
+本文件现**不含任何测试函数**，pytest 收集 0 个用例。
+
+仍待真实实现的场景（需求不因移除空壳而丢失）
+------------------------------------------
+1. Activity Mutual Interest 不直接创建 Match（INV-014）
+2. 一方确认不创建 Match（INV-015）
+3. 双方确认后创建新 Match Episode
+4. 已有 active Match 时不重复创建（AGENTS.md #19）
+5. 曾 Unmatch 后重新确认创建新 Episode（AGENTS.md #20）
+6. 一方拒绝则不创建 Match
+7. 超时（expires_at）处理
+8. 单向意向不泄露给对方（INV-006）
+
+现状补充（Phase 23 实测）
+------------------------
+INV-014 / INV-015 在后端已有**真实行为测试**覆盖：
+`backend/.../activity_mutual/ActivityMutualConsentServiceTest`
+（双确认 Gate、decline 不建 Match、复用已有 active Match、幂等、超时、软删过滤）。
+即：E2E 层待补，但不变量本身并非无覆盖。
+
+真实可执行的 V1.1 E2E 见：`tests/e2e/run_v11_tests.py`
 """
-
-import pytest
-
-
-@pytest.mark.e2e
-class TestActivityMutualConsent:
-    """活动互选二阶段同意流程测试"""
-
-    def test_mutual_interest_does_not_create_match(self, api_client, activity_factory, user_a, user_b):
-        """Activity Mutual Interest不直接创建Match（INV-014）"""
-        # TODO: P16 实现后完善
-        # Given: A和B在活动后互选
-        # When: 系统处理互选结果
-        # Then: 不创建Match，创建MutualConnectionConsent
-        pass
-
-    def test_one_side_confirm_no_match(self, api_client, activity_factory, user_a, user_b):
-        """一方确认不创建Match（INV-015）"""
-        # TODO: P16 实现后完善
-        # Given: A和B已达成Mutual Activity Interest
-        # When: 只有A确认开启沟通
-        # Then: 不创建Match，不创建Conversation
-        pass
-
-    def test_both_confirm_creates_match_episode(self, api_client, activity_factory, user_a, user_b):
-        """双方确认后创建新Match Episode"""
-        # TODO: P16 实现后完善
-        pass
-
-    def test_existing_active_match_not_duplicated(self, api_client, activity_factory, user_a, user_b):
-        """已有active Match不重复创建"""
-        # TODO: P16 实现后完善
-        pass
-
-    def test_prior_unmatch_creates_new_episode(self, api_client, activity_factory, user_a, user_b):
-        """已Unmatch后重新确认创建新Episode"""
-        # TODO: P16 实现后完善
-        pass
-
-    def test_one_side_decline_no_match(self, api_client, activity_factory, user_a, user_b):
-        """一方拒绝不创建Match"""
-        # TODO: P16 实现后完善
-        pass
-
-    def test_timeout_handled(self, api_client, activity_factory, user_a, user_b):
-        """超时处理"""
-        # TODO: P16 实现后完善
-        pass
-
-    def test_single_interest_not_leaked(self, api_client, activity_factory, user_a, user_b):
-        """单向意向不泄露给对方"""
-        # TODO: P16 实现后完善
-        pass