test(phase23): KEEP-VERIFY — remove 44 pass shells + fake INV tests, add shell guard

Phase 23 "可信系统测试重建 (REFACTOR)" re-audit. STATUS claimed "10 E2E
files / ~80+ cases" and "INV-011~020 ✅"; measurement showed the opposite.

D-23-A (Critical): V11InvariantsTest's 14 cases asserted only Constants
strings. INV-016 "Banner target types" actually asserted ARTICLE_STATUS_*;
INV-017 "home 8 entries" declared local arrays then asserted
firstRow.length == 4 (tautology, never called the home service);
INV-018/019/020 used appointment/article/account status constants as
stand-ins for permission and data-scope checks. Rewritten to 12 cases:
4 real service-behavior guards (INV-013 via real CounselingService.getDetail
— Matchmaker sees null userRequestSummary, with an assigned-Counselor
counter-proof so global sanitization cannot fake a pass; INV-016 reads the
production ALLOWED_TARGET_TYPES whitelist and asserts no external/http/url/
web entry; INV-017 calls real getHome and pins all 8 codes + order;
INV-019 asserts content_editor reads null), plus assertBehaviorTestExists
turning "行为验证见 XxxTest" pointers into executable Class.forName contracts.

D-23-B (High): 44 `pass` shells across 6 files in tests/e2e (4 files were
100% shells). Gate forbids skip/pass shells. Rewritten in place as honest
placeholders with the full scenario lists preserved.

D-23-C (High, residual): the pytest E2E suite is not executable at all —
no conftest.py anywhere, ~15 fixtures (api_client/verified_user/
banner_factory/...) do not exist. Only run_v11_tests.py really runs
(16 cases, needs a live stack + E2E_PASSWORD).

D-23-D (High, residual, NOT fixed): CI does not chain E2E as the plan
requires. Needs an infrastructure decision on how CI provisions a live
stack; not implemented rather than written unverified.

D-23-E (Medium): the CI migration job claimed to "验证 migration SQL 语法"
but only checked file non-emptiness, while the real syntax/baseline checks
live in MigrationValidationTest (already run by the backend job). Replaced
with a real sequence check (naming / non-empty / unique versions / no
gaps); verified by extracting the exact inline script and running it.

New gate: scripts/check-no-empty-tests.py (AST scan, blocks pass-only and
unconditionally skipped tests) + a CI test-shell-guard job. Verified both
ways: 0 findings on the real tree, 2 precise findings on injected shells.

Negative validation: 3 injected production defects (external_url in the
banner whitelist, swapped home entry order, isMatchmaker returning the full
record) turned exactly inv016/inv017/inv013 red, 9 others green, zero
unrelated failures; md5sum -c confirmed byte-identical restore.

Full regression: 655 tests / 652 passed / 0 failures / 0 errors / 3 skipped
(baseline 657; -2 because 14 vacuous cases were merged into 12). The 3
skips carry explicit reasons (2x @EnabledIfEnvironmentVariable(CI=true),
1x @Disabled "需要完整数据库连接") — none is a shell.

Phase 23 is PARTIALLY closed: fake coverage is gone, but the UAT gate
requires the end-to-end chain to actually execute, so "失败为零可进入 UAT"
is NOT claimed.

tests/e2e/counseling_v11_test.py

@@ -106,11 +106,18 @@ def test_counselor_assigned_scope():
 
 
 # ---- INV-013: Matchmaker不能读取Counseling正文 ----
-def test_matchmaker_cannot_read_counseling_body():
-    """红娘不得查看咨询正文内容（通过权限隔离）"""
-    # 此测试需要实际的红娘 token，验证其无 counseling.service.view 权限
-    # 在当前测试框架下简化验证：仅确认 Counselor 端点不被普通用户访问
-    pass
+# Phase 23 KEEP-VERIFY（2026-09-18）：原 test_matchmaker_cannot_read_counseling_body
+# 的函数体为 `pass` 空壳（注释自述「在当前测试框架下简化验证」），从未真实断言过任何权限，
+# 却在 docs/STATUS.md 中被计为 P23-T06「咨询 E2E ✅」的一部分。
+# 计划 Phase 23 Gate「不允许 skip/pass 空壳」→ 已移除该空壳。
+#
+# INV-013 现由后端真实行为用例覆盖：
+#   backend/.../invariants/V11InvariantsTest#inv013MatchmakerCannotReadCounselingBody
+#   走真实 CounselingService.getDetail：断言 Matchmaker 读到的 user_request_summary 为 null，
+#   并以「assigned Counselor 能读到正文」作反证，避免全局脱敏造成的假阳性；
+#   已通过负向注入验证（把 isMatchmaker 分支改为返回全文 → 该用例精准变红）。
+#
+# E2E 层待补场景：用真实红娘 token 调用咨询详情接口并断言被拒。
 
 
 if __name__ == "__main__":