test(phase23): KEEP-VERIFY — remove 44 pass shells + fake INV tests, add shell guard
Phase 23 "可信系统测试重建 (REFACTOR)" re-audit. STATUS claimed "10 E2E
files / ~80+ cases" and "INV-011~020 ✅"; measurement showed the opposite.
D-23-A (Critical): V11InvariantsTest's 14 cases asserted only Constants
strings. INV-016 "Banner target types" actually asserted ARTICLE_STATUS_*;
INV-017 "home 8 entries" declared local arrays then asserted
firstRow.length == 4 (tautology, never called the home service);
INV-018/019/020 used appointment/article/account status constants as
stand-ins for permission and data-scope checks. Rewritten to 12 cases:
4 real service-behavior guards (INV-013 via real CounselingService.getDetail
— Matchmaker sees null userRequestSummary, with an assigned-Counselor
counter-proof so global sanitization cannot fake a pass; INV-016 reads the
production ALLOWED_TARGET_TYPES whitelist and asserts no external/http/url/
web entry; INV-017 calls real getHome and pins all 8 codes + order;
INV-019 asserts content_editor reads null), plus assertBehaviorTestExists
turning "行为验证见 XxxTest" pointers into executable Class.forName contracts.
D-23-B (High): 44 `pass` shells across 6 files in tests/e2e (4 files were
100% shells). Gate forbids skip/pass shells. Rewritten in place as honest
placeholders with the full scenario lists preserved.
D-23-C (High, residual): the pytest E2E suite is not executable at all —
no conftest.py anywhere, ~15 fixtures (api_client/verified_user/
banner_factory/...) do not exist. Only run_v11_tests.py really runs
(16 cases, needs a live stack + E2E_PASSWORD).
D-23-D (High, residual, NOT fixed): CI does not chain E2E as the plan
requires. Needs an infrastructure decision on how CI provisions a live
stack; not implemented rather than written unverified.
D-23-E (Medium): the CI migration job claimed to "验证 migration SQL 语法"
but only checked file non-emptiness, while the real syntax/baseline checks
live in MigrationValidationTest (already run by the backend job). Replaced
with a real sequence check (naming / non-empty / unique versions / no
gaps); verified by extracting the exact inline script and running it.
New gate: scripts/check-no-empty-tests.py (AST scan, blocks pass-only and
unconditionally skipped tests) + a CI test-shell-guard job. Verified both
ways: 0 findings on the real tree, 2 precise findings on injected shells.
Negative validation: 3 injected production defects (external_url in the
banner whitelist, swapped home entry order, isMatchmaker returning the full
record) turned exactly inv016/inv017/inv013 red, 9 others green, zero
unrelated failures; md5sum -c confirmed byte-identical restore.
Full regression: 655 tests / 652 passed / 0 failures / 0 errors / 3 skipped
(baseline 657; -2 because 14 vacuous cases were merged into 12). The 3
skips carry explicit reasons (2x @EnabledIfEnvironmentVariable(CI=true),
1x @Disabled "需要完整数据库连接") — none is a shell.
Phase 23 is PARTIALLY closed: fake coverage is gone, but the UAT gate
requires the end-to-end chain to actually execute, so "失败为零可进入 UAT"
is NOT claimed.
This commit is contained in:
WorkBuddy
+42
-85
@@ -1,87 +1,44 @@
|
||||
"""
|
||||
V1.1 首页 E2E 测试骨架
|
||||
测试项目: 善缘丹阳 V1.1 首页结构 + Banner + 8核心入口
|
||||
V1.1 首页 E2E —— 空壳已移除（Phase 23 KEEP-VERIFY，2026-09-18）
|
||||
|
||||
历史问题
|
||||
--------
|
||||
原文件 9 个测试函数中 **7 个是 `pass` 空壳**，其余 5 个虽含断言，
|
||||
但全部依赖 `api_client` / `authenticated_user` / `banner_factory` /
|
||||
`user_factory` / `verified_user` / `searching_user` / `paused_user` /
|
||||
`successful_user` / `admin_client` 等**在本仓库中根本不存在**的 pytest fixture
|
||||
（全局无 `conftest.py`）→ 整个文件**一次都没执行过**，
|
||||
却在 `docs/STATUS.md` 中被计为 P23-T01~T04「首页 E2E ✅」。
|
||||
|
||||
计划 Phase 23 Gate：「**不允许 skip/pass 空壳**」。
|
||||
|
||||
当前状态
|
||||
--------
|
||||
本文件现**不含任何测试函数**，pytest 收集 0 个用例。
|
||||
|
||||
仍待真实实现的场景（需求不因移除空壳而丢失）
|
||||
------------------------------------------
|
||||
1. `GET /api/v1/home` 返回 userState
|
||||
2. Banner 按时间过滤（未开始 / 已过期不显示）
|
||||
3. Banner 按 audience_scope 过滤
|
||||
4. 首页 8 核心入口顺序固定（INV-017）
|
||||
5. 未审核用户不返回真实推荐
|
||||
6. Paused 用户不返回新推荐
|
||||
7. Successful 用户不返回找对象推荐
|
||||
8. 服务站可展示
|
||||
9. Banner 不能创建外部 URL 跳转（INV-016）
|
||||
10. `counselingEnabled` flag 控制 `canApplyCounseling`
|
||||
11. Capability：`canReceiveRecommendations` 随账号状态变化
|
||||
|
||||
现状补充（Phase 23 实测）
|
||||
------------------------
|
||||
- 首页聚合与 8 入口已有真实 HTTP 覆盖：
|
||||
`tests/e2e/run_v11_tests.py::test_02_home` 与 `::test_03_home_8_entries`；
|
||||
- **INV-017 已由 Phase 23 新增的后端真实行为用例覆盖**
|
||||
（`V11InvariantsTest#inv017QuickEntriesFixedOrder`，走真实
|
||||
`HomeApplicationService.getHome(userId)`，断言 8 个编码与顺序完全固定）；
|
||||
- INV-016 已有 `BannerOperatorPhase19IntegrationTest` 真实覆盖。
|
||||
即：E2E 层待补，但不变量本身已有真实覆盖。
|
||||
|
||||
真实可执行的 V1.1 E2E 见：`tests/e2e/run_v11_tests.py`
|
||||
"""
|
||||
|
||||
import pytest
|
||||
|
||||
|
||||
@pytest.mark.e2e
|
||||
class TestHomeV11:
|
||||
"""V1.1 首页 E2E 测试"""
|
||||
|
||||
def test_home_api_returns_user_state(self, api_client, authenticated_user):
|
||||
"""GET /api/v1/home 返回 userState"""
|
||||
resp = api_client.get("/api/v1/home")
|
||||
assert resp.status_code == 200
|
||||
data = resp.json()
|
||||
assert "userState" in data
|
||||
|
||||
def test_home_banners_filtered_by_time(self, api_client, banner_factory):
|
||||
"""Banner按时间过滤：未开始和已过期的Banner不显示"""
|
||||
# TODO: P07 实现后完善
|
||||
pass
|
||||
|
||||
def test_home_banners_filtered_by_audience(self, api_client, banner_factory, user_factory):
|
||||
"""Banner按用户状态过滤：audience_scope不匹配时不显示"""
|
||||
# TODO: P07 实现后完善
|
||||
pass
|
||||
|
||||
def test_home_quick_entries_fixed_order(self, api_client):
|
||||
"""首页8核心入口顺序固定"""
|
||||
# TODO: P07 实现后完善
|
||||
pass
|
||||
|
||||
def test_unverified_user_no_recommendations(self, api_client, unverified_user):
|
||||
"""未审核用户不返回真实推荐"""
|
||||
resp = api_client.get("/api/v1/home")
|
||||
data = resp.json()
|
||||
assert data.get("recommendations") == [] or data.get("recommendations") is None
|
||||
|
||||
def test_paused_user_no_new_recommendations(self, api_client, paused_user):
|
||||
"""Paused状态用户不返回新推荐"""
|
||||
resp = api_client.get("/api/v1/home")
|
||||
data = resp.json()
|
||||
# Paused用户应有推荐区降级提示，而非空列表
|
||||
assert "recommendations" in data or "userState" in data
|
||||
|
||||
def test_successful_user_no_match_recommendations(self, api_client, successful_user):
|
||||
"""Successful用户不返回找对象推荐"""
|
||||
resp = api_client.get("/api/v1/home")
|
||||
data = resp.json()
|
||||
# Successful用户首页应转为公益服务推荐
|
||||
pass
|
||||
|
||||
def test_service_location_shown_when_available(self, api_client, service_location_factory):
|
||||
"""服务站可展示"""
|
||||
# TODO: P19 实现后完善
|
||||
pass
|
||||
|
||||
def test_banner_cannot_link_external_url(self, admin_client):
|
||||
"""Banner不能创建外部URL跳转"""
|
||||
# TODO: P19 实现后完善
|
||||
pass
|
||||
|
||||
|
||||
@pytest.mark.e2e
|
||||
class TestCapabilityService:
|
||||
"""CapabilityService 能力判断测试"""
|
||||
|
||||
def test_can_receive_recommendations(self, api_client, searching_user):
|
||||
"""Searching用户canReceiveRecommendations=true"""
|
||||
resp = api_client.get("/api/v1/home")
|
||||
data = resp.json()
|
||||
caps = data.get("capabilities", {})
|
||||
assert caps.get("canReceiveRecommendations") is True
|
||||
|
||||
def test_paused_user_cannot_receive_recommendations(self, api_client, paused_user):
|
||||
"""Paused用户canReceiveRecommendations=false"""
|
||||
resp = api_client.get("/api/v1/home")
|
||||
data = resp.json()
|
||||
caps = data.get("capabilities", {})
|
||||
assert caps.get("canReceiveRecommendations") is False
|
||||
|
||||
def test_counseling_enabled_capability(self, api_client, verified_user):
|
||||
"""counselingEnabled flag控制canApplyCounseling"""
|
||||
# TODO: P22 实现后完善
|
||||
pass
|
||||
|
||||
Reference in New Issue
Block a user