Phase 23 closed as PARTIAL: fake coverage was gone, but the E2E layer itself
was still empty — no conftest.py anywhere, ~15 fixtures that never existed,
6 files crashing at import on os.environ["E2E_PASSWORD"], and CI never ran E2E.
STATUS's "10 E2E files / ~80+ cases ✅" described files that had never executed.
Infrastructure delivered:
- tests/e2e/conftest.py: ApiClient (trust_env=False — a host http_proxy turns
localhost calls into 502), operator_token(username) / new_user / admin_token
fixtures, and a session probe that calls pytest.exit(4) when the stack is
unreachable. NOT skip: skip would launder "did not run" into "passed".
- pytest.ini, tests/e2e/requirements.txt, and tests/e2e/sql/
seed_e2e_operators.sql — migrations contain NO operator seed at all, so a
fresh database has zero logins; the seed creates 6 e2e accounts with role
bindings, idempotent, password injected via `psql -v pwd`.
- CI job `e2e`: compose up -> poll /health/live (timeout = fail) -> seed ->
pytest -> always teardown. Gate D-23-D is now closed.
- 8 E2E files migrated off import-time env reads; tautological assertions
(`x == t or not x`), a counselor token standing in for content_editor, and a
bare `status_code == 200` claiming to prove INV-020 were replaced with real
permission/behavior assertions.
Six real production defects found only by running against real PostgreSQL
(H2 has zero coverage for all of them):
- D-23B-A (Critical): stale V042__add_appointment_operator_register_permission.sql
left in target/classes; src had replaced it with V042__add_service_location_
announcements.sql. Packing without clean put two V042 in the jar -> Flyway
"Found more than one migration with version 042" -> app would not start.
Guard added: testBuildOutputHasNoDuplicateMigrationVersions scans build output
(src is clean, so only this catches it).
- D-23B-B (High): non-UUID path variable reached the DB -> 500 + leaked
`invalid input syntax for type uuid`. Now rejected at the controller.
- D-23B-C (High): 6 E2E files raised KeyError at import -> never collected.
- D-23B-E (Critical): permissions = 48, role_permissions for super_admin = 18,
matchmaker = 0. V015's "grant all to super_admin" was a point-in-time snapshot;
the 30 permissions added later were never granted. On a fresh stack an admin
cannot create a service station and matchmakers can do nothing. V044 restores
super_admin to its documented definition (not an expansion); the matchmaker
permission set needs a product decision and is left as a residual.
- D-23B-I (Medium): IllegalArgumentException (e.g. invalid activity type) was
unmapped -> 500. Now BAD_REQUEST.
- D-23B-J (High): `operator does not exist: uuid = character varying` — Java
ids are String, columns are uuid, PostgreSQL does not implicitly cast in
comparisons. Fixed at the source with JDBC `stringtype=unspecified` (docker
profile); production datasource comes from deploy env and needs the same.
One judgement retracted: an initial read suggested service_appointment.register
was missing. It is not — the endpoint uses service.assisted_registration, seeded
in V029, and the code deliberately avoids a duplicate permission. Nothing was
changed on that basis.
Verification: 33 E2E passed against a live stack; unreachable stack and a
missing operator password both exit 4 (never skip/pass); backend regression
656 / 0 failures / 0 errors / 3 skipped (baseline 655, +1 guard, negatively
validated by injecting a duplicate V042 -> exactly one test turned red).
209 lines
6.7 KiB
YAML
209 lines
6.7 KiB
YAML
name: CI/CD Pipeline
|
||
|
||
on:
|
||
push:
|
||
branches: [main, develop]
|
||
pull_request:
|
||
branches: [main, develop]
|
||
|
||
jobs:
|
||
backend:
|
||
name: Backend Build & Test
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Set up JDK 21
|
||
uses: actions/setup-java@v4
|
||
with:
|
||
java-version: '21'
|
||
distribution: 'temurin'
|
||
cache: maven
|
||
working-directory: backend
|
||
|
||
- name: Build and Test
|
||
working-directory: backend
|
||
run: mvn verify -B
|
||
|
||
- name: Upload Test Results
|
||
if: always()
|
||
uses: actions/upload-artifact@v4
|
||
with:
|
||
name: backend-test-results
|
||
path: backend/target/surefire-reports/
|
||
|
||
admin-web:
|
||
name: Admin Web Build
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Set up Node.js
|
||
uses: actions/setup-node@v4
|
||
with:
|
||
node-version: '20'
|
||
cache: 'pnpm'
|
||
cache-dependency-path: admin-web/pnpm-lock.yaml
|
||
|
||
- name: Install Dependencies
|
||
working-directory: admin-web
|
||
run: pnpm install --frozen-lockfile
|
||
|
||
- name: Build
|
||
working-directory: admin-web
|
||
run: pnpm build
|
||
|
||
miniapp:
|
||
name: Mini Program Compile Check
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Set up Node.js
|
||
uses: actions/setup-node@v4
|
||
with:
|
||
node-version: '20'
|
||
|
||
- name: Install Dependencies
|
||
working-directory: miniapp
|
||
run: npm install
|
||
|
||
- name: TypeScript Compile Check
|
||
working-directory: miniapp
|
||
run: npx tsc --noEmit
|
||
|
||
migration:
|
||
name: Migration Validation
|
||
runs-on: ubuntu-latest
|
||
needs: [backend]
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Set up Python
|
||
uses: actions/setup-python@v5
|
||
with:
|
||
python-version: '3.11'
|
||
|
||
# Phase 23 KEEP-VERIFY:本步骤原注释称「验证 migration SQL 语法」,实际只检查文件非空,
|
||
# 属名不副实的假校验(SQL 语法与基线表完整性由后端测试 MigrationValidationTest 覆盖,
|
||
# 该测试随 backend job 的 `mvn verify` 运行)。现改为该测试未覆盖的**序列**校验。
|
||
- name: 迁移序列校验(命名 / 非空 / 版本号唯一 / 无缺号)
|
||
run: |
|
||
python3 - <<'PY'
|
||
import re, sys, pathlib, collections
|
||
|
||
d = pathlib.Path("backend/src/main/resources/db/migration")
|
||
files = sorted(d.glob("V*.sql"))
|
||
if not files:
|
||
sys.exit("ERROR: 未找到任何迁移文件")
|
||
|
||
vers, bad_name, empty = [], [], []
|
||
for f in files:
|
||
m = re.match(r"V(\d+)__", f.name)
|
||
if not m:
|
||
bad_name.append(f.name)
|
||
continue
|
||
if f.stat().st_size == 0:
|
||
empty.append(f.name)
|
||
vers.append(int(m.group(1)))
|
||
|
||
problems = []
|
||
if bad_name:
|
||
problems.append(f"迁移文件命名不合规(应为 V<序号>__<描述>.sql): {bad_name}")
|
||
if empty:
|
||
problems.append(f"空迁移文件: {empty}")
|
||
dups = sorted(v for v, c in collections.Counter(vers).items() if c > 1)
|
||
if dups:
|
||
problems.append(f"迁移版本号重复: {dups}")
|
||
gaps = [v for v in range(min(vers), max(vers) + 1) if v not in set(vers)]
|
||
if gaps:
|
||
problems.append(f"迁移版本号缺号: {gaps}")
|
||
|
||
if problems:
|
||
for p in problems:
|
||
print("ERROR: " + p, file=sys.stderr)
|
||
sys.exit(1)
|
||
|
||
print(f"OK: {len(files)} 个迁移文件,版本 {min(vers)}~{max(vers)} 连续且唯一")
|
||
PY
|
||
|
||
test-shell-guard:
|
||
name: Test Shell Guard (Phase 23 Gate)
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Set up Python
|
||
uses: actions/setup-python@v5
|
||
with:
|
||
python-version: '3.11'
|
||
|
||
# Phase 23 Gate:「不允许 skip/pass 空壳」。
|
||
# 机械阻断空壳回归 —— 详见 scripts/check-no-empty-tests.py。
|
||
- name: 禁止 skip/pass 空壳测试
|
||
run: python3 scripts/check-no-empty-tests.py tests
|
||
|
||
e2e:
|
||
name: E2E (live stack)
|
||
runs-on: ubuntu-latest
|
||
# Phase 23 遗留 D-23-D:计划要求 CI 串联 E2E。此前 E2E 从未真正执行过——
|
||
# 无 conftest、fixture 不存在、文件在 import 期就崩。本 job 起真实栈后执行。
|
||
needs: [backend, migration]
|
||
env:
|
||
E2E_BASE_URL: http://localhost:8085/api/v1
|
||
# CI 专用测试口令,仅存在于 runner 运行期,不入库、不用于任何真实环境
|
||
E2E_OPERATOR_PASSWORD: ci-e2e-only-password
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- uses: actions/setup-python@v5
|
||
with:
|
||
python-version: '3.11'
|
||
|
||
- name: Install E2E dependencies
|
||
run: pip install -r tests/e2e/requirements.txt
|
||
|
||
- name: 生成 CI 测试用 .env(仅运行期存在,不入库)
|
||
run: |
|
||
cat > infrastructure/.env <<'ENV'
|
||
DB_PASSWORD=ci-e2e-db-password
|
||
REDIS_PASSWORD=ci-e2e-redis-password
|
||
MINIO_ACCESS_KEY=ci-e2e-minio
|
||
MINIO_SECRET_KEY=ci-e2e-minio-secret
|
||
JWT_ACCESS_SECRET=ci-e2e-access-secret-only-for-ci
|
||
JWT_REFRESH_SECRET=ci-e2e-refresh-secret-only-for-ci
|
||
ENCRYPTION_KEY=0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
|
||
WECHAT_APP_SECRET=
|
||
ENV
|
||
|
||
- name: 起真实栈(postgres + redis + backend)
|
||
working-directory: infrastructure
|
||
run: docker compose up -d --build postgres redis backend
|
||
|
||
- name: 等待 backend 就绪(超时即失败,不静默跳过)
|
||
run: |
|
||
for i in $(seq 1 60); do
|
||
if curl -sf "$E2E_BASE_URL/health/live" > /dev/null; then
|
||
echo "backend READY after ${i} checks"; exit 0
|
||
fi
|
||
sleep 5
|
||
done
|
||
echo "::error::backend 未在 5 分钟内就绪"
|
||
docker compose -f infrastructure/docker-compose.yml logs backend
|
||
exit 1
|
||
|
||
- name: Seed E2E 运营账号(迁移不含 operator 种子,全新库无账号可登录)
|
||
working-directory: infrastructure
|
||
run: |
|
||
docker compose exec -T postgres psql -U postgres -d danyang_match \
|
||
-v pwd="$E2E_OPERATOR_PASSWORD" -f - < ../tests/e2e/sql/seed_e2e_operators.sql
|
||
|
||
- name: Run E2E
|
||
run: pytest -v
|
||
|
||
- name: Teardown(无论成败都清理并留日志)
|
||
if: always()
|
||
run: |
|
||
docker compose -f infrastructure/docker-compose.yml logs backend || true
|
||
docker compose -f infrastructure/docker-compose.yml down -v || true
|